Fix JS error due to missing element #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conditions to show the explanation for m1 support are inconsistent. The one that triggers the explanation uses version<=? and the one that creates the explanation uses version<?. Therefore, when the version is exactly version-before-m1-support, it attempts to show the explanation that doesn't exist. This PR makes the adjustment to make the conditions consistent. Based on the name `version-before-m1-support`, version<? seems to be the right one to use. Fixes #336
sorawee
force-pushed
the
fix-m1-element-missing
branch
from
f330f11 to
4557010
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conditions to show the explanation for m1 support are inconsistent. The one that triggers the explanation uses
version<=?and the one that creates the explanation usesversion<?. Therefore, when the version is exactlyversion-before-m1-support, it attempts to show the explanation that doesn't exist.This PR makes the adjustment to make the conditions consistent. Based on the name
version-before-m1-support,version<?seems to be the right one to use.Fixes #336