Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit f330f11

Browse files
committedNov 23, 2024·
Fix JS error due to missing element
The conditions to show the explanation for m1 support are inconsistent. The one that triggers the explanation uses version<? and the one that creates the explanation uses version<=?. Therefore, when the version is exactly version-before-m1-support, it attempts to show the explanation that doesn't exist. This PR makes the adjustment to make the conditions consistent. Based on the name `version-before-m1-support`, version<? seems to be the right one to use. Fixes #336
1 parent ae66639 commit f330f11

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed
 

‎download/download-pages.rkt

+1-1
Original file line numberDiff line numberDiff line change
@@ -792,7 +792,7 @@ var property = null;
792792
}
793793
null)
794794

795-
@(if (version<=? version-before-m1-support version)
795+
@(if (version<? version-before-m1-support version)
796796
@list{
797797
@; showWhen('m1_mac_explain', platform === 'x86_64-macosx');
798798
showWhen('intel_mac_explain', platform === 'aarch64-macosx');

0 commit comments

Comments
 (0)
Please sign in to comment.