-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First shot at a unified proposal #103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this PR is a good first proposal for such a unified solution. If such a solution can fit all the use cases, I'm happy to further work on this.
Co-authored-by: Quentin De Coninck <[email protected]>
Co-authored-by: Quentin De Coninck <[email protected]>
Co-authored-by: mirjak <[email protected]>
The commit a230bc1 applies the changes suggested in the previous reviews. With those changes, I think we have a good basis for discussing a unified solution in the working group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions to remove NULL CID mentions, but overall this seems a good basis for further discussion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some very minor comments.
Co-authored-by: Med <[email protected]>
Co-authored-by: Med <[email protected]>
Co-authored-by: Med <[email protected]>
Co-authored-by: Med <[email protected]>
Co-authored-by: Med <[email protected]>
Co-authored-by: Med <[email protected]>
Thanks @boucadair for the review. I have applied the editorial changes. You are asking for something more regarding the "specific logic" required when supporting zero-length CID. There are in fact two pieces to that: logic at the receiver, i.e., the node that chose to receive packets with zero-length CID; and logic at the sender, i.e., the node that accepts to send data on multiple paths towards a node that uses zero-length CID. This is explained in details in the section "Using Zero-Length connection ID", so I guess what we need is a reference to that section. |
Co-authored-by: Quentin De Coninck <[email protected]>
Co-authored-by: Quentin De Coninck <[email protected]>
Co-authored-by: Med <[email protected]>
Co-authored-by: mirjak <[email protected]>
Co-authored-by: mirjak <[email protected]>
Co-authored-by: mirjak <[email protected]>
Co-authored-by: mirjak <[email protected]>
Co-authored-by: mirjak <[email protected]>
Co-authored-by: mirjak <[email protected]>
Co-authored-by: mirjak <[email protected]>
This derives from the discussions on issue #96