Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First shot at a unified proposal #103

Merged
merged 45 commits into from
Jul 7, 2022
Merged

First shot at a unified proposal #103

merged 45 commits into from
Jul 7, 2022

Conversation

huitema
Copy link
Contributor

@huitema huitema commented Mar 4, 2022

This derives from the discussions on issue #96

Copy link
Contributor

@Yanmei-Liu Yanmei-Liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me.

Copy link
Contributor

@qdeconinck qdeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this PR is a good first proposal for such a unified solution. If such a solution can fit all the use cases, I'm happy to further work on this.

@huitema
Copy link
Contributor Author

huitema commented Mar 17, 2022

The commit a230bc1 applies the changes suggested in the previous reviews. With those changes, I think we have a good basis for discussing a unified solution in the working group.

Copy link
Contributor

@qdeconinck qdeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions to remove NULL CID mentions, but overall this seems a good basis for further discussion.

Copy link
Contributor

@boucadair boucadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very minor comments.

@huitema
Copy link
Contributor Author

huitema commented Jun 9, 2022

Thanks @boucadair for the review. I have applied the editorial changes. You are asking for something more regarding the "specific logic" required when supporting zero-length CID. There are in fact two pieces to that: logic at the receiver, i.e., the node that chose to receive packets with zero-length CID; and logic at the sender, i.e., the node that accepts to send data on multiple paths towards a node that uses zero-length CID. This is explained in details in the section "Using Zero-Length connection ID", so I guess what we need is a reference to that section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Choosing between a single packet number space vs. multiple packet number spaces
6 participants