Skip to content

test: discount packages without source information in rpm-manifest #1540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions test/rpmtest/manifest.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,12 @@ func PackagesFromManifest(t *testing.T, items iter.Seq[catalog.RpmsItems]) iter.
t.Errorf("#%03d: (%#v) unable to determine version: %v", n, it, err)
continue
}

if it.SrpmName == "" && it.SrpmNEVRA == "" {
// This is a binary package with no source information. This can be discounted.
continue
}

// Newer images produced from Konflux shove all the source information
// into the SourceName and omit the SourceNEVRA. Try both.
//
Expand Down