test: discount packages without source information in rpm-manifest #1540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/api/containers/v1/images/id/{img_id}/rpm-manifest now returns a lot of
packages in the response for different architectures. These packages
don't have any source information. This was causing test errors when
trying to convert them into `claircore.Package`s. This patch ignores
pacakges that don't contain full source information.
Signed-off-by: crozzy <[email protected]>
|
Closes #1538 |
|
I tackled this by changing this |
But won't the test fail before it even gets to comparing if the source info isn't in the response, e.g: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/api/containers/v1/images/id/{img_id}/rpm-manifest now returns a lot of packages in the response for different architectures. These packages don't have any source information. This was causing test errors when trying to convert them into
claircore.Packages. This patch ignores pacakges that don't contain full source information.