Skip to content

Arm backend: Enable CPPCHECK linting #19509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
perheld wants to merge 1 commit into
base: main
Choose a base branch
from
+47 −4
Open

Arm backend: Enable CPPCHECK linting #19509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/claude-code.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
uses: pytorch/test-infra/.github/workflows/_claude-code.yml@main
with:
setup_script: |
pip install lintrunner==0.12.7 lintrunner-adapters==0.13.0
pip install lintrunner==0.12.7 lintrunner-adapters==0.14.0
pip install -r requirements-lintrunner.txt
lintrunner init
permissions:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
- name: Install dependencies
run: |
pip install torch --index-url https://download.pytorch.org/whl/cpu
pip install lintrunner==0.12.7 lintrunner-adapters==0.13.0
pip install lintrunner==0.12.7 lintrunner-adapters==0.14.0
pip install -r requirements-lintrunner.txt
USE_CPP=0 pip install --no-build-isolation third-party/ao
pip install pytest numpy parameterized huggingface_hub transformers timm expecttest types-requests
Expand Down Expand Up @@ -93,7 +93,7 @@ jobs:

- name: Install lintrunner and linters
run: |
pip install lintrunner==0.12.7 lintrunner-adapters==0.13.0
pip install lintrunner==0.12.7 lintrunner-adapters==0.14.0
pip install -r requirements-lintrunner.txt
lintrunner init

Expand Down
39 changes: 39 additions & 0 deletions .lintrunner.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,45 @@ init_command = [
]
is_formatter = true

[[linter]]
code = 'CPPCHECK'
include_patterns = [
'backends/arm/**/*.cpp',
'backends/arm/**/*.h',
'backends/arm/**/*.hpp',
'examples/arm/**/*.cpp',
Comment thread
perheld marked this conversation as resolved.
'examples/arm/**/*.h',
'examples/arm/**/*.hpp',
]
exclude_patterns = [
]
command = [
'python',
'-m',
'lintrunner_adapters',
'run',
'cppcheck_linter',
'--enable=warning,style,unusedFunction',
Comment thread
perheld marked this conversation as resolved.
'--extra-arg=--check-level=exhaustive',
'--extra-arg=--std=c++17',
'--extra-arg=--language=c++',
'--extra-arg=--inline-suppr',
'--extra-arg=--inconclusive',
'--extra-arg=--suppress=unusedStructMember',
'--extra-arg=--suppress=toomanyconfigs',
'--',
'@{{PATHSFILE}}'
]
init_command = [
'python',
'-m',
'lintrunner_adapters',
'run',
'pip_init',
'--dry-run={{DRYRUN}}',
'--requirement=requirements-lintrunner.txt',
]

[[linter]]
code = 'CMAKE'
include_patterns = [
Expand Down
2 changes: 1 addition & 1 deletion requirements-dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ wheel # For building the pip package archive.
zstd # Imported by resolve_buck.py.
certifi # Imported by resolve_buck.py.
lintrunner==0.12.7
lintrunner-adapters==0.13.0
lintrunner-adapters==0.14.0
Comment thread
perheld marked this conversation as resolved.

pytest<9.0
pytest-xdist
Expand Down
4 changes: 4 additions & 0 deletions requirements-lintrunner.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,7 @@ docformatter==1.7.5

# MyPy
mypy==1.14.1

# Cppcheck and dependencies
cppcheck==1.5.1
defusedxml==0.7.1
Loading