Skip to content

Arm backend: Enable CPPCHECK linting#19509

Open
perheld wants to merge 1 commit into
pytorch:mainfrom
perheld:change-1246135
Open

Arm backend: Enable CPPCHECK linting#19509
perheld wants to merge 1 commit into
pytorch:mainfrom
perheld:change-1246135

Conversation

@perheld
Copy link
Copy Markdown
Collaborator

@perheld perheld commented May 12, 2026

Bump lintrunner-adapters to 0.14.0 which supports cppcheck and start linting the arm backend.

Change-Id: I1b28466d7f78d006a38b8d3c711670991cbc327a

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani

Copilot AI review requested due to automatic review settings May 12, 2026 11:58
@perheld perheld added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes labels May 12, 2026
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 12, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19509

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 5 New Failures, 6 Unrelated Failures

As of commit f78454c with merge base f1062a7 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 12, 2026
@perheld
Copy link
Copy Markdown
Collaborator Author

perheld commented May 12, 2026

After this patch I have a bunch that fixes and enables more directories.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables CPPCHECK linting for the Arm backend by adding a new lintrunner linter configuration and updating the lintrunner-adapters version to one that supports cppcheck.

Changes:

  • Bump lintrunner-adapters to 0.14.0.
  • Add CPPCHECK linter configuration targeting Arm backend/example C++ sources.
  • Add cppcheck (and dependency defusedxml) to the lintrunner requirements set.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
requirements-lintrunner.txt Adds cppcheck and a dependency to the linter-only requirements so lintrunner can install them.
requirements-dev.txt Updates lintrunner-adapters pin to a version that supports cppcheck.
.lintrunner.toml Introduces a new CPPCHECK linter entry to lint Arm backend/example C++ sources.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .lintrunner.toml
Comment thread .lintrunner.toml
Comment thread requirements-dev.txt
Signed-off-by: Per Held <per.held@arm.com>
Change-Id: I1b28466d7f78d006a38b8d3c711670991cbc327a
@zingo
Copy link
Copy Markdown
Collaborator

zingo commented May 12, 2026

Hi @digantdesai this one is a bit outside Arm stuff and we think it might need a Meta look.

@zingo zingo added the help wanted Extra attention is needed label May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. help wanted Extra attention is needed partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants