Arm backend: Enable CPPCHECK linting#19509
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19509
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 5 New Failures, 6 Unrelated FailuresAs of commit f78454c with merge base f1062a7 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
After this patch I have a bunch that fixes and enables more directories. |
There was a problem hiding this comment.
Pull request overview
Enables CPPCHECK linting for the Arm backend by adding a new lintrunner linter configuration and updating the lintrunner-adapters version to one that supports cppcheck.
Changes:
- Bump
lintrunner-adaptersto0.14.0. - Add
CPPCHECKlinter configuration targeting Arm backend/example C++ sources. - Add
cppcheck(and dependencydefusedxml) to the lintrunner requirements set.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
requirements-lintrunner.txt |
Adds cppcheck and a dependency to the linter-only requirements so lintrunner can install them. |
requirements-dev.txt |
Updates lintrunner-adapters pin to a version that supports cppcheck. |
.lintrunner.toml |
Introduces a new CPPCHECK linter entry to lint Arm backend/example C++ sources. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Per Held <per.held@arm.com> Change-Id: I1b28466d7f78d006a38b8d3c711670991cbc327a
|
Hi @digantdesai this one is a bit outside Arm stuff and we think it might need a Meta look. |
Bump lintrunner-adapters to 0.14.0 which supports cppcheck and start linting the arm backend.
Change-Id: I1b28466d7f78d006a38b8d3c711670991cbc327a
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani