TypeVisitor and Co now support allow_interpreted_subclasses=True#9602
Merged
Conversation
Now these types can be extended from plugin code. More context: #9001 (comment)
msullivan
approved these changes
Oct 18, 2020
msullivan
left a comment
msullivan
left a comment
Collaborator
There was a problem hiding this comment.
Yeah, this is a good idea. It'll increase our generated code size but shouldn't slow things down.
TH3CHARLie
pushed a commit
that referenced
this pull request
Feb 26, 2021
…10125) Currently a very important tool - which `NodeVisitor` definitely is - is not available to be used in a 3rd party code. Because currently inheriting from `NodeVisitor` raises an exception: `TypeError: interpreted classes cannot inherit from compiled traits` A developer has a single choice to replicate the same visitor pattern by themselves, which is not really convenient. So, I propose to make this consistent with `TypeVisitor`, which already allows having interpreted subclasses. Refs a9fa9ab Refs #9001 Refs #9602
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Now these types can be extended from plugin code.
Previously it was impossible:
Was giving:
But, this is a very powerful tool. Some complex type manipulations do require this (or similar) tool.
For example:
to_iterableconverter dry-python/returns#391KindNinstances like inList[KindN[...]]do not translate to the correct type dry-python/returns#631More context: #9001 (comment)
Test Plan
I actually don't have any test plan at the moment. I would be very happy to receive any advice! 👍