Adds ability to have subclasses for NodeVisitor and TraverserVisitor#10125
Merged
Conversation
Currently a very important tool - which `NodeVisitor` definitely is - is not available to be used in a 3rd party code. Because currently inheriting from `NodeVisitor` raises an exception: `TypeError: interpreted classes cannot inherit from compiled traits` A developer has a single choice to replicate the same visitor patter by theyself, which is not really convenient. So, I propose to make this consistent with `TypeVisitor`, which already allows having interpreted subclasses. Refs a9fa9ab Refs #9001 Refs #9602
TH3CHARLie
approved these changes
Feb 21, 2021
TH3CHARLie
left a comment
TH3CHARLie
left a comment
Collaborator
There was a problem hiding this comment.
I like this as long as it wouldn't cause serious performance loss due to larger generated code.
TH3CHARLie
changed the title
|
When a version with these fixes will be released ? |
|
I don't think that this is working in Mypy from mypy.visitor import ExpressionVisitor
class SafePositionVisitor(ExpressionVisitor[None]):
......fails to import as a plugin with: |
|
It looks like #10125 (comment) is due mypyc/mypyc#754. Thanks @JukkaL! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently a very important tool - which
NodeVisitordefinitely is - is not available to be used in a 3rd party code.Because currently inheriting from
NodeVisitorraises an exception:TypeError: interpreted classes cannot inherit from compiled traitsA developer has a single choice to replicate the same visitor patter by theyself, which is not really convenient.
So, I propose to make this consistent with
TypeVisitor, which already allows having interpreted subclasses.Refs a9fa9ab
Refs #9001
Refs #9602
Test Plan
As #9602 have shown, this is fine without tests.
Correct me if I am wrong, please, and I would contribute the required tests. CC @msullivan on this.