-
-
Notifications
You must be signed in to change notification settings - Fork 32.9k
gh-138568: make it the same behavior in repl help mode #138569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yihong0618
wants to merge
12
commits into
python:main
Choose a base branch
from
yihong0618:hy/make_help_mode_the_same_as_doc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
f1eba0c
fix: make it the same behavior in repl help mode
yihong0618 9e16e68
fix: address commnets add tests and better news
yihong0618 b50ffbb
更新 2025-09-06-08-29-08.gh-issue-138568.iZlalC.rst
yihong0618 575462a
fix: lint and words
yihong0618 4201a09
Update Misc/NEWS.d/next/Library/2025-09-06-08-29-08.gh-issue-138568.i…
yihong0618 7462dbb
fix: address comments
yihong0618 6fa1136
Update Lib/pydoc.py
yihong0618 3b4915a
fix: move the news to core and buildins dir
yihong0618 2babb7d
fix: apply suggestions from code review
yihong0618 4cae1c2
fix: the tests
yihong0618 2c4944c
fix: test wrong on windows
yihong0618 64d9f36
Apply suggestions from code review
yihong0618 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
Misc/NEWS.d/next/Core_and_Builtins/2025-09-06-08-29-08.gh-issue-138568.iZlalC.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
Adjusted the built-in :func:`help` function so that empty inputs are ignored in | ||
interactive mode. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think the following is cleaner than having the extra
.isspace
call. I don't think we're actually saving a string allocation that way, either, since in the case where we would be continuing,.strip()
would take us down to the empty string, which is interned.But this is a judgement call, and it's ultimately up to @AA-Turner.