gh-138568: make it the same behavior in repl help mode

[yihong0618]

as diff and doc:
To quit this help utility and return to the interpreter,
enter "q", "quit" or "exit".

• Issue: The exit behavior is not the same as the doc help mode in repl #138568

[AA-Turner]

This needs a test. The wording of the NEWS entry should also be significantly improved, it's highly unclear at present.

A

[bedevere-app]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[yihong0618]

This needs a test. The wording of the NEWS entry should also be significantly improved, it's highly unclear at present.

copy that, will try to make it better thanks for the review

[yihong0618]

This needs a test. The wording of the NEWS entry should also be significantly improved, it's highly unclear at present.

A

Done sorry for my English...the better news help with LLM

[AA-Turner]

Please be aware of our policy on use of LLMs and 'generative AI': https://devguide.python.org/getting-started/generative-ai/

[yihong0618]

Please be aware of our policy on use of LLMs and 'generative AI': https://devguide.python.org/getting-started/generative-ai/

thank you for let me know that.seems ok here, if not I will change to my own words
Thank you for the kindness again

Assistance with writing comments, especially in a non-native language

[yihong0618]

changed it to my own

[ZeroIntensity]

@adqm Would you care to review this, considering your recent work with help?

[adqm]

Thanks @yihong0618! I think this is indeed an improvement to the interactive help prompt.

I have a few suggestions, though (one behavioral change, a few stylistic things with the test cases, and a suggested rephrasing of the NEWS entry).

Of course, @ZeroIntensity and @AA-Turner should feel free to chime in if they disagree with any of my suggestions.

[yihong0618]

Thanks @yihong0618! I think this is indeed an improvement to the interactive help prompt.

I have a few suggestions, though (one behavioral change, a few stylistic things with the test cases, and a suggested rephrasing of the NEWS entry).

Of course, @ZeroIntensity and @AA-Turner should feel free to chime in if they disagree with any of my suggestions.

Thank you its very helpful but two things seem we need to disscuss

1. do we need to handle empty string in this patch, since I wonder it is another issue and break change
2. is it needs to add a helper function for two tests in unittest, the code is quite simple and right, but I am not sure it worth

Thanks again

[yihong0618]

@adqm Hi the tests code changes but the strip one seems not right in my env

[adqm]

Can you clarify the way in which you think this is not working? For example, an input that you provided that gave different output from expected?

For me, it seems to work (I tested this before sending my first review). Both an empty input and an input consisting only of spaces result in just returning me to a new prompt, and asking for help about other things still gives me appropriate help output.

[yihong0618]

Can you clarify the way in which you think this is not working? For example, an input that you provided that gave different output from expected?

For me, it seems to work (I tested this before sending my first review). Both an empty input and an input consisting only of spaces result in just returning me to a new prompt, and asking for help about other things still gives me appropriate help output.

in my side “ ” in help mode
with or without this patch are the same
it shows the str help

[adqm]

Yes, if you wrap it in quotes you will get the str help. But if you just type some number of spaces with no quotation marks it should be ignored and return you to the prompt. Same goes for length-0 strings; with quotes the input isn't ignored (we see the usage suggestions), but without quotes (i.e., just hitting Enter at the prompt) it just returns you to the prompt.

That feels like the expected behavior to me. I think the handling of " " (with the quotation marks) is surprising, but changing that does feel like a separate issue.

[yihong0618]

Yes, if you wrap it in quotes you will get the str help. But if you just type some number of spaces with no quotation marks it should be ignored and return you to the prompt. Same goes for length-0 strings; with quotes the input isn't ignored (we see the usage suggestions), but without quotes (i.e., just hitting Enter at the prompt) it just returns you to the prompt.

That feels like the expected behavior to me. I think the handling of " " (with the quotation marks) is surprising, but changing that does feel like a separate issue.

Get it you are right will change it thank you very much

[adqm]

LGTM. One more minor note from me, and then we'll wait and see what @AA-Turner thinks.

Thanks!

[AA-Turner]

Two minor suggestions, OK otherwise.

A

[yihong0618]

Two minor suggestions, OK otherwise.

A

checked its better thanks the hint

---

will fix the test

[adqm]

One more thought about the updated test cases.

[yihong0618]

One more thought about the updated test cases.

of course its better will commit and check

[adqm]

Looks good to me! Just one lingering thought.

[adqm]

I still think the following is cleaner than having the extra .isspace call. I don't think we're actually saving a string allocation that way, either, since in the case where we would be continuing, .strip() would take us down to the empty string, which is interned.

But this is a judgement call, and it's ultimately up to @AA-Turner.

Suggested change

	if not request or request.isspace():
	continue # back to the prompt
	request = request.strip()
	request = request.strip()
	if not request:
	continue # back to the prompt