Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-128690: Use test_embed in PGO profile builds again #129377

Closed
wants to merge 1 commit into from

Conversation

neonene
Copy link
Contributor

@neonene neonene commented Jan 27, 2025

This reverts the temporal commit b00e125.

The issue with test_init_pyvenv_cfg failing is closed as resolved.

cc @ned-deily

@vstinner
Copy link
Member

test_embed is slow and mostly spawns sub-processes. I'm not convinced that it's an useful tests to train the PGO build.

cc @pablogsal @corona10 @markshannon

@neonene
Copy link
Contributor Author

neonene commented Jan 31, 2025

I'd prefer a more explicit announcement if test_embed will not be used in PGO. Also, I'd prefer older versions (3.10 to 3.13) to have the same conditions.

@vstinner
Copy link
Member

vstinner commented Feb 3, 2025

I'd prefer a more explicit announcement if test_embed will not be used in PGO. Also, I'd prefer older versions (3.10 to 3.13) to have the same conditions.

I suggest to also remove test_embed from 3.12 and 3.13 in this case, and document the change in the Build category.

@neonene
Copy link
Contributor Author

neonene commented Feb 4, 2025

I suggest to also remove test_embed from 3.12 and 3.13 in this case, and document the change in the Build category.

I have opened #129660.

@neonene neonene closed this Feb 4, 2025
@neonene neonene deleted the restore_embed branch February 5, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants