Skip to content

Drop test_embed from PGO training #129660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
neonene opened this issue Feb 4, 2025 · 0 comments
Closed

Drop test_embed from PGO training #129660

neonene opened this issue Feb 4, 2025 · 0 comments
Labels
type-feature A feature request or enhancement

Comments

@neonene
Copy link
Contributor

neonene commented Feb 4, 2025 •
edited by bedevere-app bot
Loading

Feature or enhancement

Proposal:

The number of unit tests for PGO profile build was reduced in gh-80225 (bpo-36044). Additionally, recent versions of CPython could skip test_embed, which is considered to have become bigger for its contribution.

The git-main has already disabled it in b00e125, which should be explicit and backported to compare benchmarks rationally.

Has this already been discussed elsewhere?

No response given

Links to previous discussion of this feature:

#129377

Linked PRs
@neonene neonene added the type-feature A feature request or enhancement label Feb 4, 2025
This was referenced Feb 4, 2025
Merged
Merged
@neonene neonene mentioned this issue Feb 4, 2025
Closed
@neonene neonene changed the title Drop test_embed from PGO exercises Drop test_embed from PGO training Feb 4, 2025
vstinner pushed a commit that referenced this issue Feb 4, 2025
@neonene
gh-129660: Do not use test_embed in PGO profile builds (#129661)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
285c1c4
vstinner pushed a commit that referenced this issue Feb 5, 2025
@neonene
[3.13] gh-129660: Do not use test_embed in PGO profile builds (#129662)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
19ceb34
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Feb 5, 2025
@neonene @miss-islington
[3.13] pythongh-129660: Do not use test_embed in PGO profile builds (p…
Loading
Loading status checks…
a8dc3f8 
…ythonGH-129662)

(cherry picked from commit 19ceb34)

Co-authored-by: neonene <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Feb 5, 2025
Merged
@vstinner vstinner closed this as completed Feb 5, 2025
vstinner pushed a commit that referenced this issue Feb 5, 2025
@miss-islington @neonene
[3.12] gh-129660: Do not use test_embed in PGO profile builds (GH-129662

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
62fafd8 
) (#129685)

[3.13] gh-129660: Do not use test_embed in PGO profile builds (GH-129662)
(cherry picked from commit 19ceb34)

Co-authored-by: neonene <[email protected]>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Feb 7, 2025
@neonene @srinivasreddy
pythongh-129660: Do not use test_embed in PGO profile builds (python#…
791540c 
…129661)
cmaloney pushed a commit to cmaloney/cpython that referenced this issue Feb 8, 2025
@neonene @cmaloney
pythongh-129660: Do not use test_embed in PGO profile builds (python#…
3f12bb0 
…129661)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vstinner @neonene