Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using deprecated --no-python-version-warning option #1913

Merged
merged 2 commits into from
Apr 7, 2025
+2 −6
Merged

Stop using deprecated --no-python-version-warning option #1913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da1313f
Stop using `--no-python-version-warning`
edgarrmondragon Feb 13, 2025
a0e3aca
Merge branch 'master' into remove--no-python-version-warning
edgarrmondragon Mar 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions backend/tests/downstream/integrate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,6 @@ def main():
'download',
'-q',
'--disable-pip-version-check',
'--no-python-version-warning',
'-d',
links_dir,
os.path.join(links_dir, os.listdir(links_dir)[0]),
Expand Down Expand Up @@ -230,7 +229,6 @@ def main():
'install',
'-q',
'--disable-pip-version-check',
'--no-python-version-warning',
'--find-links',
links_dir,
'--no-deps',
Expand All @@ -243,7 +241,6 @@ def main():
'install',
'-q',
'--disable-pip-version-check',
'--no-python-version-warning',
repo_dir,
])

Expand Down
2 changes: 1 addition & 1 deletion src/hatch/cli/application.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ def ensure_plugin_dependencies(self, dependencies: list[Requirement], *, wait_me

pip_command = [sys.executable, '-u', '-m', 'pip']

pip_command.extend(['install', '--disable-pip-version-check', '--no-python-version-warning'])
pip_command.extend(['install', '--disable-pip-version-check'])

# Default to -1 verbosity
add_verbosity_flag(pip_command, self.verbosity, adjustment=-1)
Expand Down
2 changes: 1 addition & 1 deletion src/hatch/env/plugin/interface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -768,7 +768,7 @@ def construct_pip_install_command(self, args: list[str]):
A convenience method for constructing a [`pip install`](https://pip.pypa.io/en/stable/cli/pip_install/)
command with the given verbosity. The default verbosity is set to one less than Hatch's verbosity.
"""
command = ['python', '-u', '-m', 'pip', 'install', '--disable-pip-version-check', '--no-python-version-warning']
command = ['python', '-u', '-m', 'pip', 'install', '--disable-pip-version-check']

# Default to -1 verbosity
add_verbosity_flag(command, self.verbosity, adjustment=-1)
Expand Down
1 change: 0 additions & 1 deletion tests/helpers/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ def assert_plugin_installation(subprocess_run, dependencies: list[str], *, verbo
'pip',
'install',
'--disable-pip-version-check',
'--no-python-version-warning',
]
add_verbosity_flag(command, verbosity, adjustment=-1)
command.extend(dependencies)
Expand Down
Loading