Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using deprecated --no-python-version-warning option #1913

Merged
merged 2 commits into from
Apr 7, 2025
Merged

Stop using deprecated --no-python-version-warning option #1913

merged 2 commits into from
Apr 7, 2025

Conversation

edgarrmondragon
Copy link
Contributor

@edgarrmondragon edgarrmondragon commented Feb 13, 2025 •
edited
Loading

@edgarrmondragon edgarrmondragon changed the title Stop using deprecated --no-python-version-warning Stop using deprecated --no-python-version-warning option Feb 13, 2025
@edgarrmondragon
Copy link
Contributor Author

Those two failing tests are also failing on master:

FAILED tests/dep/test_sync.py::test_dependency_git_uv - AssertionError: assert not True
FAILED tests/dep/test_sync.py::test_dependency_git_revision_uv - AssertionError: assert not True

@return42
Copy link

Thanks for PR .. just want to refer: pip v25.0 (2025-01-26) Deprecations and Removals

@return42
Copy link

@ofek ping .. sorry for being so pushy, but I think this will break hatch when next pip minor version is released ..

DEPRECATION: --no-python-version-warning is deprecated. pip 25.1 will enforce this behaviour change.

.. thanks a lot 👍

@ofek
Copy link
Collaborator

ofek commented Feb 25, 2025

I will work on this over the weekend.

@djcopley djcopley mentioned this pull request Mar 20, 2025
Closed
@potiuk potiuk mentioned this pull request Mar 23, 2025
Closed
@potiuk
Copy link
Contributor

potiuk commented Mar 23, 2025

Would be nice to merge / release that one. It's a bit worrying as the flag will be removed from pip very soon.

ofek
ofek approved these changes Apr 7, 2025
View reviewed changes
Copy link
Collaborator

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the wait.

@ofek ofek merged commit 3b203e3 into pypa:master Apr 7, 2025
50 checks passed
@edgarrmondragon edgarrmondragon deleted the remove--no-python-version-warning branch April 7, 2025 02:20
github-actions bot pushed a commit that referenced this pull request Apr 7, 2025
@ofek
Stop using deprecated --no-python-version-warning option (#1913)
d4b65f8 
Stop using `--no-python-version-warning` 3b203e3
@edgarrmondragon
Copy link
Contributor Author

Sorry for the wait.

No worries at all! Thanks for merging :)

ofek pushed a commit that referenced this pull request Apr 7, 2025
@edgarrmondragon @ofek
Stop using deprecated --no-python-version-warning option (#1913)
1538938 
Stop using `--no-python-version-warning`
github-actions bot pushed a commit to Stars1233/hatch that referenced this pull request Apr 7, 2025
@pull
Stop using deprecated --no-python-version-warning option (pypa#1913)
0399c1d 
Stop using `--no-python-version-warning` 3b203e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

@ofek ofek ofek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edgarrmondragon @return42 @ofek @potiuk