-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Better histogram control (plus pygfx histogram overhaul) #146
base: main
Are you sure you want to change the base?
Conversation
Not much utility to a slider
Makes log work, but more importantly makes for better histogram interaction and cleaner logic
Will save for another PR
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #146 +/- ##
==========================================
- Coverage 80.68% 79.73% -0.95%
==========================================
Files 44 44
Lines 4209 4417 +208
==========================================
+ Hits 3396 3522 +126
- Misses 813 895 +82 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
also great stuff here. if implementing the slider was problematic, i'm fine with a button for now. I was recently playing with histograms as well, and trying to apply range limits (so that the thing doesn't scroll past, for example, 0-65,535). I think it's pretty straightforward using the 1DPanZoom camera, and updating the I'll have a closer look at the changes required here soon. thanks! |
Useful for histograms right now but potentially for array canvases as well?
Let me know what you think of 5bf0f1e - could use a little polish but I think it works pretty well. |
I don't think this applies anymore
Since the goal is to not move the camera when updating data, without this change we'll never set the camera to the right place the first time!
8621b37
to
6c79110
Compare
6c79110
to
f9500d1
Compare
Not sure how I feel about this addition to the model, but it's very useful!
Particular review going to acedb6e would be worthwhile, as it adds a new field
as well as #152, which this PR would now close. However there may be a better place to store this state... |
b79aaa1
to
5e983b2
Compare
5e983b2
to
7afd5ad
Compare
3e66df0
to
5139aba
Compare
This PR adds:
To accomplish these features, some serious TLC was required to accomodate the new histogram features using pygfx. The way that we were calculating the margins was becoming increasingly complicated, so I developed a new strategy where the plot, x-axis, and y-axis are all rendered separately. This enables us to easily:
The downside here is more complication in the rendering pipeline, but I think it's better than it was.
Recording.2025-02-28.213811.mp4
These controls should be ready for opinions (cc @tlambert03, @fdrgsp), but also still need to:
FIXME
s