-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add autoscale tail ignore via context menu [WIP] #147
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
=======================================
Coverage 80.68% 80.68%
=======================================
Files 44 44
Lines 4209 4256 +47
=======================================
+ Hits 3396 3434 +38
- Misses 813 822 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
thanks @gselzer, this would indeed be great to have. Couple thoughts at this point:
|
Good ideas. Have updated in the latest commit: If you're a fan of this now I'll investigate how/whether we can do similar things in wx (where I'm more confident) and jupyter (less confident) |
Yes, but I agree that separate settings are sometimes desirable. I thought a bit about whether people would want the option of editing just one number, but then again, it doesn't make theoretical sense to use the same number for the read noise at the bottom and the shot noise at the top (for example). It would only be a heuristic convenience. Given that in many cases you'd only need a non-zero percentile for the upper limit (I think?), it seems fine (and simplest) to just have two fields. |
This PR adds GUI functionality for autoscaling using
ClimsPercentile
, where the user can ignore the outlier samples of the dataset being displayed in autoscale:Recording.2025-02-28.214155.mp4
I like the placement as a context menu because it means all autoscaling functionality appears within the same area of the canvas and because it normally does not take up any screen space.
Unfortunately, I do not know whether this design is possible with all our frontends, seeing as how I cannot figure out how to write a context menu in ipywidgets.
We might instead have to settle for adding this widget to the layouts added in #146...