Skip to content

Fix false "start_url is missing" validation error for manifests without name field #5121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix false "start_url is missing" validation error for manifests without name field #5121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23717ee
Initial plan
Copilot Oct 6, 2025
cf367e6
Fix manifest validation logic and removeEmptyFields
Copilot Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions components/code-editor/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 6 additions & 10 deletions components/manifest-editor/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions components/manifest-editor/src/components/manifest-icons-form.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,11 @@ const platformsData: Array<PlatformInformation> = [
export class ManifestIconsForm extends LitElement {

@property({type: Object, hasChanged(value: Manifest, oldValue: Manifest) {
if(value !== oldValue && value.name){
if(value !== oldValue){
manifestInitialized = true;
return value !== oldValue;
return true;
}
return value !== oldValue;
return false;
}}) manifest: Manifest = {};

@property({type: String}) manifestURL: string = "";
Expand Down
6 changes: 3 additions & 3 deletions components/manifest-editor/src/components/manifest-info-form.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@ let infoFields = ["name", "short_name", "description", "background_color", "them
export class ManifestInfoForm extends LitElement {

@property({type: Object, hasChanged(value: Manifest, oldValue: Manifest) {
if(value !== oldValue && value.name){
if(value !== oldValue){
manifestInitialized = true;
return value !== oldValue;
return true;
}
return value !== oldValue;
return false;
}}) manifest: Manifest = {};

@property({type: String}) focusOn: string = "";
Expand Down
6 changes: 3 additions & 3 deletions components/manifest-editor/src/components/manifest-platform-form.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@ let fieldsValidated: boolean = false;
export class ManifestPlatformForm extends LitElement {

@property({type: Object, hasChanged(value: Manifest, oldValue: Manifest) {
if(value !== oldValue && value.name){
if(value !== oldValue){
manifestInitialized = true;
return value !== oldValue;
return true;
}
return value !== oldValue;
return false;
}}) manifest: Manifest = {};

@property({type: String}) focusOn: string = "";
Expand Down
6 changes: 3 additions & 3 deletions components/manifest-editor/src/components/manifest-screenshots-form.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@ let manifestInitialized = false;
export class ManifestScreenshotsForm extends LitElement {

@property({type: Object, hasChanged(value: Manifest, oldValue: Manifest) {
if(value !== oldValue && value.name){
if(value !== oldValue){
manifestInitialized = true;
return value !== oldValue;
return true;
}
return value !== oldValue;
return false;
}}) manifest: Manifest = {};
@property({type: String}) manifestURL: string = "";
@property({type: String}) baseURL: string = "";
Expand Down
6 changes: 3 additions & 3 deletions components/manifest-editor/src/components/manifest-settings-form.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@ let manifestInitialized: boolean = false;
export class ManifestSettingsForm extends LitElement {

@property({type: Object, hasChanged(value: Manifest, oldValue: Manifest) {
if(value !== oldValue && value.name){
if(value !== oldValue){
manifestInitialized = true;
return value !== oldValue;
return true;
}
return value !== oldValue;
return false;
}}) manifest: Manifest = {};

private shouldValidateAllFields: boolean = true;
Expand Down
6 changes: 3 additions & 3 deletions components/manifest-editor/src/components/manifest-share-form.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@ let manifestInitialized = false;
export class ManifestShareForm extends LitElement {

@property({type: Object, hasChanged(value: Manifest, oldValue: Manifest) {
if(value !== oldValue && value.name){
if(value !== oldValue){
manifestInitialized = true;
return value !== oldValue;
return true;
}
return value !== oldValue;
return false;
}}) manifest: Manifest = {};

@property({type: String}) manifestURL: string = "";
Expand Down
6 changes: 3 additions & 3 deletions components/manifest-editor/src/components/pwa-manifest-editor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,9 @@ export class PWAManifestEditor extends LitElement {
}

private removeEmptyFields(manifest: Manifest): Manifest {
var new_manifest: Manifest = manifest;
for(const key in manifest) {
const value = manifest[key];
var new_manifest: Manifest = {...manifest};
for(const key in new_manifest) {
const value = new_manifest[key];
if((typeof value === "string" || Array.isArray(value)) && value.length === 0){
delete new_manifest[key];
}
Expand Down