Skip to content

Documentation: Add note to irradiance.haydavies docstring. Close #1352 #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cwhanse merged 3 commits into from
Dec 10, 2021
Merged

Documentation: Add note to irradiance.haydavies docstring. Close #1352 #1353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd9f4ba
PR for issue #1314
Carlosbogo Nov 5, 2021
114bfc1
Documentation: Added note to `irradiance.haydavies` docstring. Close …
Carlosbogo Dec 8, 2021
611be5e
Documentation: Add note to irradiance.haydavies docstring. Update #1353
Carlosbogo Dec 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pvlib/irradiance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -795,6 +795,12 @@ def haydavies(surface_tilt, surface_azimuth, dhi, dni, dni_extra,
sky_diffuse : numeric
The sky diffuse component of the solar radiation.

Notes
------
When supplying ``projection_ratio``, consider constraining its values
when zenith angle approaches 90 degrees or angle of incidence
projection is negative. See code for details.

References
-----------
.. [1] Loutzenhiser P.G. et. al. "Empirical validation of models to
Expand Down
2 changes: 1 addition & 1 deletion pvlib/location.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ def get_solarposition(self, times, pressure=None, temperature=12,
-------
solar_position : DataFrame
Columns depend on the ``method`` kwarg, but always include
``zenith`` and ``azimuth``.
``zenith`` and ``azimuth``. The angles are in degrees.
"""
if pressure is None:
pressure = atmosphere.alt2pres(self.altitude)
Expand Down