Documentation: Add note to irradiance.haydavies docstring. Close #1352 #1353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vlib#1352 Added a note about projection_ratio parameter to `irradiance.haydavies` docstring as mentioned by @kanderso-nrel .
kandersolar
reviewed
Dec 9, 2021
Member
kandersolar
left a comment
kandersolar
left a comment
There was a problem hiding this comment.
Thanks @Carlosbogo! FYI in the future I suggest making a new branch off master when you start a new PR so that unrelated commits don't show up. I don't think it's a problem here though.
…ib#1353 Added the changes suggested by @kanderso-nrel Co-authored-by: Kevin Anderson <[email protected]>
Member
|
@kanderso-nrel pls do the honors ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1352 by adding a note to
irradiance.haydaviesdocstring as mentioned by @kanderso-nrel.