Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JDBC Properties section #24340

Merged

Conversation

efrancisworks
Copy link
Contributor

@efrancisworks efrancisworks commented Jan 9, 2025

Add JDBC Properties section with JdbcMetadataConfig properties

Description

Add a new header JDBC Properties to Presto Session Properties

Motivation and Context

JdbcMetadataConfig session properties are undocumented. Addresses issue #23918

Impact

Helping readers of Presto documentation by improving the documentation to include currently undocumented features.

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* ... :pr:`12345`
* ... :pr:`12345`

Hive Connector Changes
* ... :pr:`12345`
* ... :pr:`12345`

If release note is NOT required, use:

== NO RELEASE NOTE ==

Add JDBC Properties section with JdbcMetadataConfig properties
@github-actions github-actions bot added the docs label Jan 9, 2025
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull branch, local doc build, looks good.

Thank you for the doc!

@efrancisworks efrancisworks marked this pull request as ready for review January 10, 2025 05:06
@efrancisworks efrancisworks requested review from elharo and a team as code owners January 10, 2025 05:06
@tdcmeehan tdcmeehan self-assigned this Jan 10, 2025
@tdcmeehan tdcmeehan merged commit 0d22e37 into prestodb:master Jan 10, 2025
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants