Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(test): update workflow file #1357

Merged
merged 3 commits into from
Feb 20, 2025
Merged

chore(test): update workflow file #1357

merged 3 commits into from
Feb 20, 2025

Conversation

cbr7
Copy link
Contributor

@cbr7 cbr7 commented Feb 20, 2025

What does this PR do?

Updates the windows cicd workflow

What issues does this PR fix or reference?

#1279

@cbr7 cbr7 linked an issue Feb 20, 2025 that may be closed by this pull request
Update the windows workflow with e2e tests to be using latest images #1279
Closed
@cbr7 cbr7 marked this pull request as ready for review February 20, 2025 11:32
@cbr7 cbr7 requested a review from a team as a code owner February 20, 2025 11:32
@cbr7 cbr7 requested review from dgolovin, jeffmaury and axel7083 and removed request for a team February 20, 2025 11:32
@cbr7
chore(test): update mapt version
6e0fe2d 
Signed-off-by: Vladimir Lazar <[email protected]>
odockal
odockal requested changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@odockal odockal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also suggest to merge ext_tests input into ext_repo_options since the limit of number of inputs if 10. Or any other input where is makes sense.

odockal
odockal approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@odockal odockal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbr7 cbr7 merged commit 6bd0484 into podman-desktop:main Feb 20, 2025
6 checks passed
@cbr7 cbr7 deleted the update_windows_workflow branch February 20, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitf benoitf benoitf approved these changes

@odockal odockal odockal approved these changes

@dgolovin dgolovin Awaiting requested review from dgolovin dgolovin is a code owner automatically assigned from podman-desktop/reviewers

@jeffmaury jeffmaury Awaiting requested review from jeffmaury jeffmaury is a code owner automatically assigned from podman-desktop/reviewers

@axel7083 axel7083 Awaiting requested review from axel7083 axel7083 is a code owner automatically assigned from podman-desktop/reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the windows workflow with e2e tests to be using latest images
3 participants
@cbr7 @benoitf @odockal