linter is not working properly in this repository #1239
Assignees
Labels
Comments
deboer-tim
added a commit
that referenced
this issue
Jan 29, 2025
Tried making a few intentional mistakes, and yes, linting was very broken in .ts and .svelte. For consistency and picking a good baseline, I started by pulling the package.json and eslint differences from the AI Lab extension, which included switching to the newer eslint.config.mjs config instead of .eslint files. Eslint is updated, and several plugins were added. Since the rules in ai-lab are stricter than when eslint stopped working here, this flagged ~160 'new' issues. This would be too much change for a single PR, so I fixed all the minor/one-off issues here, disabled rules for the top 4, and opened #1245 to enable them later. Fixes #1239. Signed-off-by: Tim deBoer <[email protected]>
Merged
deboer-tim
added a commit
that referenced
this issue
Jan 29, 2025
Tried making a few intentional mistakes, and yes, linting was very broken in .ts and .svelte. For consistency and picking a good baseline, I started by pulling the package.json and eslint differences from the AI Lab extension, which included switching to the newer eslint.config.mjs config instead of .eslint files. Eslint is updated, and several plugins were added. Since the rules in ai-lab are stricter than when eslint stopped working here, this flagged ~160 'new' issues. This would be too much change for a single PR, so I fixed all the minor/one-off issues here, disabled rules for the top 4, and opened #1245 to enable them later. Fixes #1239. Signed-off-by: Tim deBoer <[email protected]>
deboer-tim
added a commit
that referenced
this issue
Jan 29, 2025
Tried making a few intentional mistakes, and yes, linting was very broken in .ts and .svelte. For consistency and picking a good baseline, I started by pulling the package.json and eslint differences from the AI Lab extension, which included switching to the newer eslint.config.mjs config instead of .eslint files. Eslint is updated, and several plugins were added. Since the rules in ai-lab are stricter than when eslint stopped working here, this flagged ~160 'new' issues. This would be too much change for a single PR, so I fixed all the minor/one-off issues here, disabled rules for the top 4, and opened #1245 to enable them later. Fixes #1239. Signed-off-by: Tim deBoer <[email protected]>
github-project-automation
bot
moved this from 🚥 In Review
to ✔️ Done
in Podman Desktop Planning OLD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug description
I modified some svelte files and when running the pre-hook I got errors in svelte parsing file
I noticed also that the lint PR check rule is not checking the svelte file at all
Operating system
macOS
Version
next (development version)
Steps to reproduce
modify a svelte file and try to commit, see the error
Relevant log output
Additional context
No response
The text was updated successfully, but these errors were encountered: