chore: fix linting #1246
Merged
chore: fix linting #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deboer-tim
requested review from
benoitf,
dgolovin and
axel7083
and removed request for
a team
Tried making a few intentional mistakes, and yes, linting was very broken in .ts and .svelte. For consistency and picking a good baseline, I started by pulling the package.json and eslint differences from the AI Lab extension, which included switching to the newer eslint.config.mjs config instead of .eslint files. Eslint is updated, and several plugins were added. Since the rules in ai-lab are stricter than when eslint stopped working here, this flagged ~160 'new' issues. This would be too much change for a single PR, so I fixed all the minor/one-off issues here, disabled rules for the top 4, and opened #1245 to enable them later. Fixes #1239. Signed-off-by: Tim deBoer <[email protected]>
|
Rebased to fix pnpm-lock.yaml conflict, no other change. |
|
looks like there are some regressions after the rebase |
Fixes two issues found after rebasing on main and in PR check. Signed-off-by: Tim deBoer <[email protected]>
benoitf
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Tried making a few intentional mistakes, and yes, linting was very broken in .ts and .svelte.
For consistency and picking a good baseline, I started by pulling the package.json and eslint differences from the AI Lab extension, which included switching to the newer eslint.config.mjs config instead of .eslint files. Eslint is updated, and several plugins were added.
Since the rules in ai-lab are stricter than when eslint stopped working here, this flagged ~160 'new' issues. This would be too much change for a single PR, so I fixed all the minor/one-off issues here, disabled rules for the top 4, and opened #1245 to enable them later.
Screenshot / video of UI
N/A
What issues does this PR fix or reference?
Fixes #1239.
How to test this PR?
Verify changes, build/PR checks pass.