Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable additional linting rules #1245

Open
deboer-tim opened this issue Jan 29, 2025 · 0 comments
Open

Enable additional linting rules #1245

deboer-tim opened this issue Jan 29, 2025 · 0 comments
Labels
kind/enhancement ✨ Issue for requesting an improvement

Comments

@deboer-tim
Copy link
Contributor

Is your enhancement related to a problem? Please describe

While fixing #1239 I turned on a stricter rule set from the ai-lab extension and there were ~160 new linting errors.

That's a bit too much to fix in one PR or block fixing lint, so I disabled the following 4 rules with the most hits and fixed the rest:

'@typescript-eslint/no-explicit-any': 'error',
'@typescript-eslint/no-floating-promises': ['error', { ignoreVoid: false }],
'@typescript-eslint/no-misused-promises': 'error',
'@typescript-eslint/explicit-function-return-type': 'error',

Describe the solution you'd like

We should enable these rules to improve code quality.

Describe alternatives you've considered

No response

Additional context

No response

@deboer-tim deboer-tim added the kind/enhancement ✨ Issue for requesting an improvement label Jan 29, 2025
deboer-tim added a commit that referenced this issue Jan 29, 2025
Tried making a few intentional mistakes, and yes, linting was very broken in
.ts and .svelte.

For consistency and picking a good baseline, I started by pulling the package.json
and eslint differences from the AI Lab extension, which included switching to the
newer eslint.config.mjs config instead of .eslint files. Eslint is updated, and
several plugins were added.

Since the rules in ai-lab are stricter than when eslint stopped working here,
this flagged ~160 'new' issues. This would be too much change for a single PR, so I
fixed all the minor/one-off issues here, disabled rules for the top 4, and opened
#1245 to enable them later.

Fixes #1239.

Signed-off-by: Tim deBoer <[email protected]>
deboer-tim added a commit that referenced this issue Jan 29, 2025
Tried making a few intentional mistakes, and yes, linting was very broken in
.ts and .svelte.

For consistency and picking a good baseline, I started by pulling the package.json
and eslint differences from the AI Lab extension, which included switching to the
newer eslint.config.mjs config instead of .eslint files. Eslint is updated, and
several plugins were added.

Since the rules in ai-lab are stricter than when eslint stopped working here,
this flagged ~160 'new' issues. This would be too much change for a single PR, so I
fixed all the minor/one-off issues here, disabled rules for the top 4, and opened
#1245 to enable them later.

Fixes #1239.

Signed-off-by: Tim deBoer <[email protected]>
deboer-tim added a commit that referenced this issue Jan 29, 2025
Tried making a few intentional mistakes, and yes, linting was very broken in
.ts and .svelte.

For consistency and picking a good baseline, I started by pulling the package.json
and eslint differences from the AI Lab extension, which included switching to the
newer eslint.config.mjs config instead of .eslint files. Eslint is updated, and
several plugins were added.

Since the rules in ai-lab are stricter than when eslint stopped working here,
this flagged ~160 'new' issues. This would be too much change for a single PR, so I
fixed all the minor/one-off issues here, disabled rules for the top 4, and opened
#1245 to enable them later.

Fixes #1239.

Signed-off-by: Tim deBoer <[email protected]>
deboer-tim added a commit that referenced this issue Jan 29, 2025
Enable no-explicit-any linting rule and fix issues.

Part of #1245.

Signed-off-by: Tim deBoer <[email protected]>
deboer-tim added a commit that referenced this issue Jan 29, 2025
Enable no-explicit-any linting rule and fix issues.

Part of #1245.

Signed-off-by: Tim deBoer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement ✨ Issue for requesting an improvement
Projects
None yet
Development

No branches or pull requests

1 participant