Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Podman Desktop env API for all platforms #1207

Closed
deboer-tim opened this issue Jan 21, 2025 · 0 comments · Fixed by #1224
Closed

Use Podman Desktop env API for all platforms #1207

deboer-tim opened this issue Jan 21, 2025 · 0 comments · Fixed by #1224
Assignees
Labels
kind/enhancement ✨ Issue for requesting an improvement

Comments

@deboer-tim
Copy link
Contributor

Is your enhancement related to a problem? Please describe

machine-utils.ts was updated to start using the Podman Desktop env API for Mac, but Linux and Windows use os.platform instead.

Describe the solution you'd like

Use Podman Desktop env api for all platforms.

Describe alternatives you've considered

No response

Additional context

No response

@deboer-tim deboer-tim added the kind/enhancement ✨ Issue for requesting an improvement label Jan 21, 2025
@deboer-tim deboer-tim self-assigned this Jan 21, 2025
deboer-tim added a commit to deboer-tim/podman-desktop-extension-bootc that referenced this issue Jan 23, 2025
Just updates windows and linux to use PD env API instead of os.platform(), so that
it is consistent with mac. Tests mock to mac for now, as they're not doing anything
dependent on execution OS.

Fixes podman-desktop#1207.

Signed-off-by: Tim deBoer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement ✨ Issue for requesting an improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant