chore: use env for windows and linux

Just updates windows and linux to use PD env API instead of os.platform(), so that it is consistent with mac. Tests mock to mac for now, as they're not doing anything dependent on execution OS. Fixes #1207. Signed-off-by: Tim deBoer <[email protected]>
podman-desktop · Jan 30, 2025 · ea3f3da · ea3f3da
1 parent 038ab6c
commit ea3f3da
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/packages/backend/src/machine-utils.spec.ts b/packages/backend/src/machine-utils.spec.ts
@@ -1,5 +1,5 @@
 /**********************************************************************
- * Copyright (C) 2024 Red Hat, Inc.
+ * Copyright (C) 2024-2025 Red Hat, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -51,6 +51,11 @@ vi.mock('@podman-desktop/api', async () => {
         };
       },
     },
+    env: {
+      isMac: true,
+      isLinux: false,
+      isWindows: false,
+    },
     process: {
       exec: vi.fn(),
     },

diff --git a/packages/backend/src/machine-utils.ts b/packages/backend/src/machine-utils.ts
@@ -1,5 +1,5 @@
 /**********************************************************************
- * Copyright (C) 2024 Red Hat, Inc.
+ * Copyright (C) 2024-2025 Red Hat, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -165,14 +165,12 @@ function getCustomBinaryPath(): string | undefined {
   return extensionApi.configuration.getConfiguration('podman').get('binary.path');
 }
 
-const windows = os.platform() === 'win32';
 export function isWindows(): boolean {
-  return windows;
+  return env.isWindows;
 }
 
-const linux = os.platform() === 'linux';
 export function isLinux(): boolean {
-  return linux;
+  return env.isLinux;
 }
 
 export function isMac(): boolean {