chore: use env for windows and linux #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just updates windows and linux to use PD env API instead of os.platform(), so that it is consistent with mac. Tests mock to mac for now, as they're not doing anything dependent on execution OS. Fixes podman-desktop#1207. Signed-off-by: Tim deBoer <[email protected]>
deboer-tim
requested review from
benoitf,
feloy and
SoniaSandler
and removed request for
a team
benoitf
reviewed
Jan 23, 2025
| @@ -51,6 +51,11 @@ vi.mock('@podman-desktop/api', async () => { | |||
| }; | |||
| }, | |||
| }, | |||
| env: { | |||
| isMac: true, | |||
There was a problem hiding this comment.
questio: it seems it'll test only macos case in the unit tests ?
Usually it's a vi.fn function and there are tests for each os
There was a problem hiding this comment.
There are no tests that are actually platform dependent (yet), but agree, that's better for now and more obvious later. Updated.
Respond to review feedback. Signed-off-by: Tim deBoer <[email protected]>
cdrage
approved these changes
Jan 24, 2025
benoitf
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Just updates windows and linux to use PD env API instead of os.platform(), so that it is consistent with mac. Tests mock to mac for now, as they're not doing anything dependent on execution OS.
Screenshot / video of UI
N/A
What issues does this PR fix or reference?
Fixes #1207.
How to test this PR?
PR checks.