Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: make all api/v2 compatible with old TiCDC. #990

Merged
merged 5 commits into from
Feb 13, 2025

Conversation

asddongmen
Copy link
Collaborator

@asddongmen asddongmen commented Feb 13, 2025

Signed-off-by: dongmen [email protected]

What problem does this PR solve?

Issue Number: ref #989

What is changed and how it works?

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels Feb 13, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 13, 2025
Copy link

ti-chi-bot bot commented Feb 13, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-13 13:39:58.383532219 +0000 UTC m=+536640.779754279: ☑️ agreed by hongyunyan.

Copy link

ti-chi-bot bot commented Feb 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongyunyan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 13, 2025
@ti-chi-bot ti-chi-bot bot merged commit fc05f85 into pingcap:master Feb 13, 2025
11 of 12 checks passed
@asddongmen asddongmen mentioned this pull request Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants