v8.5: remove VictoriaMetrics guide #21538
Conversation
lilin90
added
the
translation/from-docs-cn
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @lilin90, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've made a temporary adjustment to the v8.5 documentation branch by removing the guide on switching from Prometheus to VictoriaMetrics. This is a precautionary step because the TiUP version (v1.16.3) that enables this functionality is not yet available. My intention is to reintroduce this documentation once the corresponding TiUP release is out, ensuring that users only see features that are fully supported and accessible.
Highlights
- Documentation Update: I have temporarily removed the "Switch from Prometheus to VictoriaMetrics" section from the
maintain-tidb-using-tiup.mdfile. - Feature Availability: This removal is a temporary measure for the
v8.5branch, as the necessary TiUP v1.16.3 version, which introduces support for VictoriaMetrics, has not yet been released.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
ti-chi-bot
bot
added
the
size/XS
There was a problem hiding this comment.
Code Review
This pull request temporarily removes the documentation for switching from Prometheus to VictoriaMetrics by commenting out the relevant section in maintain-tidb-using-tiup.md. The reason for this change is that the feature depends on a future release of TiUP (v1.16.3). The use of HTML comments to hide the section is an appropriate method for this temporary removal. The change is correct and aligns with the stated intent. I have no further feedback.
[LGTM Timeline notifier]Timeline:
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilin90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What is changed, added or deleted? (Required)
Removed VictoriaMetrics guide from
release-8.5for now, and will add it back after TiUP v1.16.3 is released.Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?