Skip to content

Conversation

hfxsd
Copy link
Collaborator

@hfxsd hfxsd commented Aug 27, 2025

Reverts #21538

@ti-chi-bot ti-chi-bot bot added the contribution This PR is from a community contributor. label Aug 27, 2025
@hfxsd hfxsd requested a review from dveeden August 27, 2025 13:54
@ti-chi-bot ti-chi-bot bot added the missing-translation-status This PR does not have translation status info. label Aug 27, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @hfxsd, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request restores the previously removed guide on switching from Prometheus to VictoriaMetrics within the TiDB documentation. This ensures that users have access to instructions for leveraging VictoriaMetrics for improved monitoring scalability and performance in large TiDB clusters.

Highlights

  • Documentation Content Restoration: The comprehensive guide detailing the process of migrating from Prometheus to VictoriaMetrics for TiDB cluster monitoring has been reinstated.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 27, 2025
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed missing-translation-status This PR does not have translation status info. labels Aug 27, 2025
@hfxsd hfxsd self-assigned this Aug 27, 2025
@hfxsd hfxsd removed the contribution This PR is from a community contributor. label Aug 27, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts a previous change, restoring the documentation for switching from Prometheus to VictoriaMetrics. The restored content is generally well-written and follows the documentation style guide. I've suggested a minor clarification to one of the steps to make it easier for users to follow.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 27, 2025
Copy link

ti-chi-bot bot commented Aug 27, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-08-27 15:37:51.585275855 +0000 UTC m=+368163.463106809: ☑️ agreed by dveeden.

@hfxsd
Copy link
Collaborator Author

hfxsd commented Aug 28, 2025

/approve

Copy link

ti-chi-bot bot commented Aug 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 28, 2025
@hfxsd hfxsd added the lgtm label Aug 28, 2025
@ti-chi-bot ti-chi-bot bot merged commit 7aa1fee into release-8.5 Aug 28, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants