-
Notifications
You must be signed in to change notification settings - Fork 3
md-04 - intelligent index creation with automatic value inference #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
azzazzel
wants to merge
27
commits into
pinecone-io:main
Choose a base branch
from
azzazzel:md-04
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
# Conflicts: # internal/pkg/cli/command/index/create.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The index creation process was complex and required users to manually specify many configuration parameters. It also required users to know the interdependencies between different flags, making it difficult for new users to get started quickly. There was no way to discover available embedding models, and users had to know the exact model names and their requirements. Additionally, there was no global option to skip confirmation prompts, making automation and scripting cumbersome.
Solution
This PR introduces intelligent index creation with automatic value inference and comprehensive model management capabilities. The changes include:
pc models
command to list available embedding models with their specifications and requirements--assume-yes
Flag: Added-y
/--assume-yes
global flag to skip all confirmation prompts for automation and scriptingThe implementation maintains full backward compatibility while significantly improving the user experience for both beginners and advanced users.
Type of Change
Test Plan
Model Discovery Testing: Test the new models command:
Intelligent Index Creation Testing: Test automatic value inference:
Global Assume-Yes Flag Testing: Test automation-friendly behavior:
Validation Testing: Test improved validation and error handling:
Backward Compatibility Testing: Ensure existing commands still work:
# Test explicit configuration (should work as before) pc index create my-index --dimension 1536 --metric cosine --cloud aws --region us-east-1
This PR builds upon the previous #36 style improvements and contains all changes in that branch as well