-
Notifications
You must be signed in to change notification settings - Fork 3
md-05 - interactive mode for index creation #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
azzazzel
wants to merge
30
commits into
pinecone-io:main
Choose a base branch
from
azzazzel:md-05
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # internal/pkg/cli/command/index/create.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
While the CLI now supports intelligent value inference and model discovery, users still need to know the exact flags and parameters to create indexes. The command-line interface can be intimidating for new users who are unfamiliar with vector database concepts or the specific configuration options available. There was no guided way to walk users through the index creation process step by step.
Solution
This PR introduces an interactive mode for index creation that guides users through the configuration process with a user-friendly interface. The changes include:
--interactive
/-i
flag to enable guided index creationThe interactive mode makes the CLI accessible to users of all skill levels while maintaining the power and flexibility of the command-line interface for advanced users.
Type of Change
Test Plan
Interactive Mode Testing: Test the new interactive mode for index creation:
Backward Compatibility Testing: Ensure non-interactive mode still works:
# Test all existing command patterns pc index create my-index --dimension 1536 --metric cosine --cloud aws --region us-east-1 pc index create my-index --model llama-text-embed-v2
Integration with Other Features: Test interactive mode with other features:
# Test with --assume-yes flag (should skip confirmations) pc index create my-index --interactive -y
This PR completes this series of user experience improvements. It builds on top of #37 and contains all the changes from the previous branches in the series.