-
Notifications
You must be signed in to change notification settings - Fork 3
md-03 - design system and standardized presentation #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
azzazzel
wants to merge
19
commits into
pinecone-io:main
Choose a base branch
from
azzazzel:md-03
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
# Conflicts: # internal/pkg/cli/command/index/create.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The CLI lacked a consistent visual design system and standardized presentation patterns across different commands. Output formatting was inconsistent, error messages were not user-friendly, and there was no centralized theming system. This resulted in a fragmented user experience with varying message styles, table presentations, and interactive components that didn't follow a cohesive design language.
Solution
This PR introduces a comprehensive style theme system and standardizes the CLI output presentation. Currently, it is implemented in the commands related to index management. The changes include:
The implementation ensures all output follows a consistent design language while maintaining backward compatibility and providing a better user experience through improved visual clarity and information hierarchy.
Type of Change
Test Plan
Color Scheme: Test different color schemes and terminal environments:
pc config show-color-scheme # to change the scheme pc config set-color-scheme light pc config set-color-scheme dark
Style System Testing: Verify that all predefined styles render correctly with and without color support:
Message Presentation Testing: Test different message types and multi-line messages:
Table Rendering Testing: Verify consistent table formatting across all commands:
Interactive Components Testing: Test confirmation dialogs and interactive elements:
This PR builds upon the previous #35 and includes all the changes from that branch as well.