-
Notifications
You must be signed in to change notification settings - Fork 0
141. Linked List Cycle #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,6 +19,7 @@ class Solution: | |
#### 思考ログ | ||
- LinkedListというデータ構造をよく理解できていなかった | ||
- 普段のコーディングでポインタという概念をあまり意識していないなと思った | ||
- わからなかったのであらいさんの回答をみた | ||
|
||
# step2 | ||
```python | ||
|
@@ -54,4 +55,38 @@ class Solution: | |
``` | ||
#### 思考ログ | ||
- step2と同じ | ||
- 回答わかっているのになぜ3回連続なんだろうと思ったが、確かに詰まっているところはしっかり理解しきれていないところだと思った。 | ||
- 回答わかっているのになぜ3回連続なんだろうと思ったが、確かに詰まっているところはしっかり理解しきれていないところだと思った。 | ||
|
||
# step4 | ||
```python | ||
class Solution: | ||
def hasCycle(self, head: Optional[ListNode]) -> bool: | ||
if head is None : | ||
return False | ||
fast = slow = head | ||
while fast is not None and fast.next is not None: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 可読性を考えると、while fast and fast.nextで良いと思いました。 |
||
fast = fast.next.next | ||
slow = slow.next | ||
if fast is slow: | ||
return True | ||
return False | ||
``` | ||
|
||
#### ハッシュテーブル | ||
```python | ||
class Solution: | ||
def hasCycle(self, head: Optional[ListNode]) -> bool: | ||
visited_nodes = set() | ||
current_node = head | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 好みですが、今回コードが短くスコープが狭いので、visited, currentでも良いかなと思いました。 |
||
while current_node: | ||
if current_node in visited_nodes: | ||
return True | ||
visited_nodes.add(current_node) | ||
current_node = current_node.next | ||
return False | ||
``` | ||
|
||
#### 思考ログ | ||
- レビューで指摘された点を修正 | ||
- ハッシュテーブルの回答もみて写経してみた | ||
- こちらのほうが思いつきやすそうだなという印象 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好みの問題ですが、自分だったらslow = fast = head (小さい、遅い方を先に持ってくる)の書き方にするかと思います。