Provide the schema for the self-update versions.json #5
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| { | ||
| "$schema": "http://json-schema.org/draft-07/schema#", | ||
| "$id": "https://example.com/versions-schema.json", | ||
| "title": "Versions Schema", | ||
| "description": "Schema for versions list for PHPCQ self-update", | ||
| "type": "object", | ||
| "properties": { | ||
| "updated": { | ||
| "type": "string", | ||
| "format": "date-time", | ||
| "description": "Timestamp of the last update" | ||
| }, | ||
| "versions": { | ||
| "type": "array", | ||
| "description": "List of available versions", | ||
| "items": { | ||
| "type": "object", | ||
| "properties": { | ||
| "version": { | ||
| "type": "string", | ||
| "description": "Version number following the semver standard" | ||
| }, | ||
| "phar": { | ||
| "type": "string", | ||
| "description": "File path of the phar file relative to the versions.json" | ||
| }, | ||
| "signature": { | ||
| "type": [ "string", "null" ], | ||
| "description": "File path of the signature file relative to the versions.json" | ||
| }, | ||
| "requirements": { | ||
| "type": "object", | ||
| "description": "Abhängigkeiten der Version", | ||
dmolineus marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "properties": { | ||
| "php": { | ||
| "type": "string", | ||
|
There was a problem hiding this comment. Can't we reuse the constraint schema here? |
||
| "description": "PHP requirement" | ||
| } | ||
| }, | ||
| "patternProperties": { | ||
| "^ext-[a-zA-Z0-9_-]+$": { | ||
| "type": "string", | ||
|
There was a problem hiding this comment. Can't we reuse the constraint schema here? |
||
| "description": "PHP extension requirement" | ||
| } | ||
| }, | ||
| "additionalProperties": true | ||
| } | ||
| }, | ||
| "required": ["version", "phar", "signature", "requirements"], | ||
| "additionalProperties": false | ||
| } | ||
| } | ||
| }, | ||
| "required": ["updated", "versions"], | ||
| "additionalProperties": false | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can re-use the PhpPlatformRequirements schema here
If we can't, the constraint schema (see below for version annotation) should at least be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably can, but we fix it first and handle all platform requirements according to https://getcomposer.org/doc/articles/composer-platform-dependencies.md#different-types-of-platform-packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is missing there?
Do you mean to restrict the name with the various prefixes?