Provide the schema for the self-update versions.json #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
discordier
requested changes
Jun 13, 2025
| }, | ||
| "patternProperties": { | ||
| "^ext-[a-zA-Z0-9_-]+$": { | ||
| "type": "string", |
There was a problem hiding this comment.
Can't we reuse the constraint schema here?
| "description": "Abhängigkeiten der Version", | ||
| "properties": { | ||
| "php": { | ||
| "type": "string", |
There was a problem hiding this comment.
Can't we reuse the constraint schema here?
| "type": [ "string", "null" ], | ||
| "description": "File path of the signature file relative to the versions.json" | ||
| }, | ||
| "requirements": { |
There was a problem hiding this comment.
Maybe we can re-use the PhpPlatformRequirements schema here
If we can't, the constraint schema (see below for version annotation) should at least be used.
There was a problem hiding this comment.
We probably can, but we fix it first and handle all platform requirements according to https://getcomposer.org/doc/articles/composer-platform-dependencies.md#different-types-of-platform-packages
There was a problem hiding this comment.
What is missing there?
Do you mean to restrict the name with the various prefixes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request introduces a new JSON Schema file for defining the structure of a versions list used in the PHPCQ self-update process.