-
-
Notifications
You must be signed in to change notification settings - Fork 0
Provide the schema for the self-update versions.json #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
}, | ||
"patternProperties": { | ||
"^ext-[a-zA-Z0-9_-]+$": { | ||
"type": "string", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we reuse the constraint schema here?
"description": "Abhängigkeiten der Version", | ||
"properties": { | ||
"php": { | ||
"type": "string", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we reuse the constraint schema here?
"type": [ "string", "null" ], | ||
"description": "File path of the signature file relative to the versions.json" | ||
}, | ||
"requirements": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can re-use the PhpPlatformRequirements schema here
If we can't, the constraint schema (see below for version annotation) should at least be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably can, but we fix it first and handle all platform requirements according to https://getcomposer.org/doc/articles/composer-platform-dependencies.md#different-types-of-platform-packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is missing there?
Do you mean to restrict the name with the various prefixes?
This Pull Request introduces a new JSON Schema file for defining the structure of a versions list used in the PHPCQ self-update process.