Skip to content

gmstrftime.xml Fix example to match description and demonstrate local… #5014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mmalferov wants to merge 2 commits into
base: master
Choose a base branch
from
Open

gmstrftime.xml Fix example to match description and demonstrate local… #5014

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96a8849
gmstrftime.xml Fix example to match description and demonstrate local…
mmalferov Nov 23, 2025
a2e82c6
Update gmstrftime.xml Fix XML syntax error
mmalferov Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions reference/datetime/functions/gmstrftime.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,11 +99,23 @@
<programlisting role="php">
<![CDATA[
<?php
setlocale(LC_TIME, 'en_US');
echo strftime("%b %d %Y %H:%M:%S", mktime(20, 0, 0, 12, 31, 98)) . "\n";
echo gmstrftime("%b %d %Y %H:%M:%S", mktime(20, 0, 0, 12, 31, 98)) . "\n";
setlocale(LC_TIME, 'es_ES.UTF-8');
date_default_timezone_set('EST');

echo strftime("%B %d %Y %H:%M:%S", mktime(20, 0, 0, 12, 31, 98)) . "\n";
echo gmstrftime("%B %d %Y %H:%M:%S", mktime(20, 0, 0, 12, 31, 98));
]]>
</programlisting>
&example.outputs;
<screen>
<![CDATA[
Deprecated: Function strftime() is deprecated since 8.1, use IntlDateFormatter::format() instead in script on line 6
diciembre 31 1998 20:00:00

Deprecated: Function gmstrftime() is deprecated since 8.1, use IntlDateFormatter::format() instead in script on line 7
enero 01 1999 01:00:00
]]>
</screen>
Comment on lines +109 to +118
Copy link
Member

@Girgias Girgias Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While at it, maybe remove the useless <para> tag around the example tag and reindent everything properly?

</example>
</para>
</refsect1>
Expand Down