gmstrftime.xml Fix example to match description and demonstrate local… #5014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e handling The description says we should see different times for local vs GMT, but both lines print the same. Also, using English locale doesn't really show what `gmstrftime` can do
Girgias
reviewed
Jan 9, 2026
Comment on lines
+109
to
+118
| &example.outputs; | ||
| <screen> | ||
| <![CDATA[ | ||
| Deprecated: Function strftime() is deprecated since 8.1, use IntlDateFormatter::format() instead in script on line 6 | ||
| diciembre 31 1998 20:00:00 | ||
| Deprecated: Function gmstrftime() is deprecated since 8.1, use IntlDateFormatter::format() instead in script on line 7 | ||
| enero 01 1999 01:00:00 | ||
| ]]> | ||
| </screen> |
Member
There was a problem hiding this comment.
While at it, maybe remove the useless <para> tag around the example tag and reindent everything properly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e handling
The description says we should see different times for local vs GMT, but both lines print the same. Also, using English locale doesn't really show what
gmstrftimecan do