Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to change auto-continue from Settings Menu #147

Merged
merged 3 commits into from
Sep 1, 2024

Conversation

amalnanavati
Copy link
Contributor

@amalnanavati amalnanavati commented Sep 1, 2024

Describe this pull request. Link to relevant GitHub issues, if any.

This PR adds another element to the settings menu that allows users to toggle auto-continue options. Although auto-continue options nominally can be toggled from the app, the issue is that once they are checked, the robot could potentially move past that screen very fast, so the user may not have time to un-toggle the auto-continue settings. This PR addresses that, by giving users another location (in the settings menu) to toggle auto-continue settings.

Explain how this pull request was tested, including but not limited to the below checkmarks.

  • Launch the code in sim mock.
  • Load the settings menu, go into Auto-Continue.
  • Verify everything looks good.
  • Toggle each of the buttons (one-at-a-time), go through a bite, verify the right buttons are toggled.

Before creating a pull request

  • Format React code with npm run format
  • Format Python code by running python3 -m black . in the top-level of this repository
  • Thoroughly test your code's functionality, including unintended uses.
  • Fully test the responsiveness of the feature as documented in the Responsiveness Testing Guidelines. If you deviate from those guidelines, document above why you deviated and what you did instead.
  • Consider the user flow between states that this feature introduces, consider different situations that might occur for the user, and ensure that there is no way for the user to get stuck in a loop.

Before merging a pull request

  • Squash all your commits into one (or Squash and Merge)

@amalnanavati amalnanavati merged commit 40622cd into main Sep 1, 2024
4 checks passed
@amalnanavati amalnanavati deleted the amaln/settings_auto_continue branch September 1, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant