forked from maxgerhardt/framework-arduinoadafruitnrf52-seeed
-
Notifications
You must be signed in to change notification settings - Fork 20
Installation fixups #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Vge0rge
wants to merge
2
commits into
pdcook:main
Choose a base branch
from
Vge0rge:installation_fixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The instructions are for the user to enter this into the "Additional Boards Manager URLs" field in Arduino IDE's "Preferences" dialog. That field only accepts a comma-delimited list of URLs.
The URL-per-line format you are suggesting can only be used in the "Additional Boards Manager URLs" dialog which is accessed by clicking the button to the right side of the "Additional Boards Manager URLs" field in the "Preferences" dialog.
If you want to instruct the user to use a URL-per-line format, you must also provide instructions for using the "Additional Boards Manager URLs" dialog. My opinion is that, in this context there isn't a significant advantage to using the "Additional Boards Manager URLs" dialog and the additional steps to access the dialog would make the instructions more difficult for the user to follow. So my suggestion is to simply specify the correct format for use in the "Additional Boards Manager URLs" field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, I could have been more clear on this. But this PR is more than 2 months old and I don't expect it ever to get merged so I don't bother updating to be honest.