-
Notifications
You must be signed in to change notification settings - Fork 20
Installation fixups #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Update the package name to avoid using spaces since it doesn't work with the Arduino IDE. Signed-off-by: Vge0rge <[email protected]>
Which is required by the nRFMicro core as a dependency. Signed-off-by: Vge0rge <[email protected]>
|
Same here, the json file doesn't bring anything to the Arduino IDE |
|
@brunocannavina did you try the json in my PR or the one in the main branch? I am trying to fix that with this PR and it did work for me. |
|
@pdcook Can you review this? |
|
any chance making this vscode platformio compatible? |
|
I am not planning to add support for platform io, I am not very familiar with it and I don't have the time at the moment. |
| https://files.seeedstudio.com/arduino/package_seeeduino_boards_index.json | ||
| https://raw.githubusercontent.com/pdcook/nRFMicro-Arduino-Core/main/package_nRFMicro_index.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| https://files.seeedstudio.com/arduino/package_seeeduino_boards_index.json | |
| https://raw.githubusercontent.com/pdcook/nRFMicro-Arduino-Core/main/package_nRFMicro_index.json | |
| https://files.seeedstudio.com/arduino/package_seeeduino_boards_index.json,https://raw.githubusercontent.com/pdcook/nRFMicro-Arduino-Core/main/package_nRFMicro_index.json |
The instructions are for the user to enter this into the "Additional Boards Manager URLs" field in Arduino IDE's "Preferences" dialog. That field only accepts a comma-delimited list of URLs.
The URL-per-line format you are suggesting can only be used in the "Additional Boards Manager URLs" dialog which is accessed by clicking the button to the right side of the "Additional Boards Manager URLs" field in the "Preferences" dialog.
If you want to instruct the user to use a URL-per-line format, you must also provide instructions for using the "Additional Boards Manager URLs" dialog. My opinion is that, in this context there isn't a significant advantage to using the "Additional Boards Manager URLs" dialog and the additional steps to access the dialog would make the instructions more difficult for the user to follow. So my suggestion is to simply specify the correct format for use in the "Additional Boards Manager URLs" field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, I could have been more clear on this. But this PR is more than 2 months old and I don't expect it ever to get merged so I don't bother updating to be honest.
Following the comments from reported issue I updated the json file and the instructions to apply the fixups reported there.
I tried this with a clean installation in Linux and it worked fine, I could download the board package and select the promicro/nice boards without issues. I also tried to compile a couple of USB and nrfCrypto samples and they seem to build as well.
Hope that helps