forked from sammchardy/python-binance
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codspeed #3
Closed
+14
−1
Closed
Codspeed #3
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a84a2ae
add timeout to jobs (#1556)
pcriadoperez cf7debb
Merge branch 'master' of https://github.com/sammchardy/python-binance
pcriadoperez 75fe302
codspeed
pcriadoperez 66d150e
fix yaml
pcriadoperez 370c457
fix dependencies
pcriadoperez b554b23
modify action
pcriadoperez ecd8f9f
run only on python 3.12
pcriadoperez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @pcriadoperez, I am a co-founder @CodSpeedHQ.
I took a look at your setup with CodSpeed, and saw that you are using matrices
It means that for each run of the workflow, there will be multiple uploads of the same benchmarks, which is currently not supported by CodSpeed.
I greatly recommend that you upload only once per workflow, and if possible with the latest python version (
3.12
), so that you can benefit from automated flamegraphs.This should do the trick: