-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codspeed #3
Codspeed #3
Conversation
CodSpeed Performance ReportCongrats! CodSpeed is installed 🎉
You will start to see performance impacts in the reports once the benchmarks are run from your default branch.
|
.github/workflows/python-app.yml
Outdated
- name: Run benchmarks | ||
uses: CodSpeedHQ/action@v3 | ||
with: | ||
token: ${{ secrets.CODSPEED_TOKEN }} | ||
run: pytest tests/ --codspeed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @pcriadoperez, I am a co-founder @CodSpeedHQ.
I took a look at your setup with CodSpeed, and saw that you are using matrices
It means that for each run of the workflow, there will be multiple uploads of the same benchmarks, which is currently not supported by CodSpeed.
I greatly recommend that you upload only once per workflow, and if possible with the latest python version (3.12
), so that you can benefit from automated flamegraphs.
This should do the trick:
- name: Run benchmarks | |
uses: CodSpeedHQ/action@v3 | |
with: | |
token: ${{ secrets.CODSPEED_TOKEN }} | |
run: pytest tests/ --codspeed | |
- name: Run benchmarks | |
if: ${{ matrix.python == '3.12' }} | |
uses: CodSpeedHQ/action@v3 | |
with: | |
token: ${{ secrets.CODSPEED_TOKEN }} | |
run: pytest tests/ --codspeed |
@adriencaccia thanks for the comment! I closed this PR to open this one that contributes to the main repo: sammchardy#1564 |
Steps before merging PR