Rename FFI bitcoin structs and specify units#1537
Merged
spacebear21 merged 2 commits intoMay 8, 2026
Merged
Conversation
Collaborator
Coverage Report for CI Build 25526869649Coverage remained the same at 85.169%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
spacebear21
force-pushed
the
dart-rename-bitcoin-structs
branch
from
7b5d9c6 to
0232521
Compare
The "Plain" prefix is awkward and doesn't add any useful information for downstream implementers.
spacebear21
force-pushed
the
dart-rename-bitcoin-structs
branch
from
0232521 to
18c01a6
Compare
spacebear21
changed the title
spacebear21
force-pushed
the
dart-rename-bitcoin-structs
branch
from
18c01a6 to
55b5e01
Compare
2 tasks
arminsabouri
approved these changes
May 8, 2026
Collaborator
arminsabouri
left a comment
arminsabouri
left a comment
There was a problem hiding this comment.
Concept + Code Ack 55b5e01
DanGould
approved these changes
May 8, 2026
Contributor
DanGould
left a comment
DanGould
left a comment
There was a problem hiding this comment.
Why were these ever prefixed Plain?
Collaborator
Author
The prefixes were introduced in https://github.com/payjoin/rust-payjoin/pull/1191/changes when we moved away from actual bitcoin ffi structs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow ups to the conversation here SatoshiPortal/bullbitcoin-mobile#2041 (comment)
Authored with Claude Opus 4.7
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.