Prepare dart package for publishing to pub.dev#1541
Draft
spacebear21 wants to merge 1 commit intopayjoin:masterfrom
Draft
Prepare dart package for publishing to pub.dev#1541spacebear21 wants to merge 1 commit intopayjoin:masterfrom
spacebear21 wants to merge 1 commit intopayjoin:masterfrom
Conversation
Collaborator
Coverage Report for CI Build 25533002088Coverage remained the same at 85.169%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT: Merge #1537 first before merging/publishing this.
Blocker:
native/Cargo.toml[patch]blocks break pub.dev consumersnative/Cargo.tomlredirectspayjoin-ffiand three workspace crates to monorepo-relative paths (../..,../../../payjoin, …). In the monorepo this letsdart testbuild the wrapper against in-tree Rustsources so newly-generated bindings get exercised against the FFI changes that produced them. For pub.dev consumers those paths don't exist.
A good solution should satisfy the following priorities, in order:
This may be achievable by using a checked in .cargo/config.toml for local dev and excluding it in .pubignore.? Or maybe just a publish script that rewrites the Cargo.toml to strip the patch sections and pin the latest rev? TBD
Remaining steps to publish (once the above lands)
From payjoin-ffi/dart/:
bash scripts/generate_bindings.shdart pub publish --dry-run: confirm lib/payjoin.dart present, no .dylib/.so/*.dll/native/target/, pubspec.yaml shows 0.1.1.dart pub publishgit tag payjoin-ffi-dart-v0.1.1 && git push upstream payjoin-ffi-dart-v0.1.1Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.