Skip to content

chore(DataList): provided context for demo icons #11966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
93 changes: 74 additions & 19 deletions packages/react-core/src/demos/DataList/examples/DataListBasic.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
DataListItemCells,
Flex,
FlexItem,
Icon,
MenuToggle,
MenuToggleCheckbox,
OverflowMenu,
Expand All @@ -28,7 +29,7 @@ import CodeIcon from '@patternfly/react-icons/dist/esm/icons/code-icon';
import CubeIcon from '@patternfly/react-icons/dist/esm/icons/cube-icon';
import ExclamationTriangleIcon from '@patternfly/react-icons/dist/esm/icons/exclamation-triangle-icon';
import CheckCircleIcon from '@patternfly/react-icons/dist/esm/icons/check-circle-icon';
import TimesCircleIcon from '@patternfly/react-icons/dist/esm/icons/times-circle-icon';
import ExclamationCircleIcon from '@patternfly/react-icons/dist/esm/icons/exclamation-circle-icon';

export const DataListBasic: React.FunctionComponent = () => {
const renderPagination = () => <Pagination itemCount={5} page={1} variant="top" isCompact />;
Expand Down Expand Up @@ -98,13 +99,22 @@ export const DataListBasic: React.FunctionComponent = () => {
<FlexItem>
<Flex spaceItems={{ default: 'spaceItemsSm' }}>
<FlexItem>
<CodeBranchIcon /> 10
<Icon>
<CodeBranchIcon />
</Icon>
10 <span className="pf-v6-screen-reader">Branches</span>
</FlexItem>
<FlexItem>
<CodeIcon /> 4
<Icon>
<CodeIcon />
</Icon>
4 <span className="pf-v6-screen-reader">Code blocks</span>
</FlexItem>
<FlexItem>
<CubeIcon /> 5
<Icon>
<CubeIcon />
</Icon>
5 <span className="pf-v6-screen-reader">Workspaces</span>
</FlexItem>
<FlexItem> Updated 2 days ago</FlexItem>
</Flex>
Expand Down Expand Up @@ -140,23 +150,41 @@ export const DataListBasic: React.FunctionComponent = () => {
<FlexItem>
<Flex spaceItems={{ default: 'spaceItemsSm' }}>
<FlexItem>
<CodeBranchIcon /> 5
<Icon>
<CodeBranchIcon />
</Icon>
5 <span className="pf-v6-screen-reader">Branches</span>
</FlexItem>
<FlexItem>
<CodeIcon /> 9
<Icon>
<CodeIcon />
</Icon>
9 <span className="pf-v6-screen-reader">Code blocks</span>
</FlexItem>
<FlexItem>
<CubeIcon /> 2
<Icon>
<CubeIcon />
</Icon>
2 <span className="pf-v6-screen-reader">Workspaces</span>
</FlexItem>
<FlexItem>
<CheckCircleIcon />
<Icon status="success">
<CheckCircleIcon />
</Icon>
11
<span className="pf-v6-screen-reader">Completed</span>
</FlexItem>
<FlexItem>
<ExclamationTriangleIcon /> 4
<Icon status="warning">
<ExclamationTriangleIcon />
</Icon>
4 <span className="pf-v6-screen-reader">Warnings</span>
</FlexItem>
<FlexItem>
<TimesCircleIcon /> 1
<Icon status="danger">
<ExclamationCircleIcon />
</Icon>
1 <span className="pf-v6-screen-reader">Error</span>
</FlexItem>
<FlexItem> Updated 2 days ago</FlexItem>
</Flex>
Expand Down Expand Up @@ -220,14 +248,23 @@ export const DataListBasic: React.FunctionComponent = () => {
<FlexItem>
<Flex spaceItems={{ default: 'spaceItemsSm' }}>
<FlexItem>
<CodeBranchIcon />
<Icon>
<CodeBranchIcon />
</Icon>
10
<span className="pf-v6-screen-reader">Branches</span>
</FlexItem>
<FlexItem>
<CodeIcon /> 4
<Icon>
<CodeIcon />
</Icon>
4 <span className="pf-v6-screen-reader">Code blocks</span>
</FlexItem>
<FlexItem>
<CubeIcon /> 5
<Icon>
<CubeIcon />
</Icon>
5 <span className="pf-v6-screen-reader">Workspaces</span>
</FlexItem>
<FlexItem> Updated 2 days ago</FlexItem>
</Flex>
Expand Down Expand Up @@ -263,22 +300,40 @@ export const DataListBasic: React.FunctionComponent = () => {
<FlexItem>
<Flex spaceItems={{ default: 'spaceItemsSm' }}>
<FlexItem>
<CodeBranchIcon /> 5
<Icon>
<CodeBranchIcon />
</Icon>
5 <span className="pf-v6-screen-reader">Branches</span>
</FlexItem>
<FlexItem>
<CodeIcon /> 9
<Icon>
<CodeIcon />
</Icon>
9 <span className="pf-v6-screen-reader">Code blocks</span>
</FlexItem>
<FlexItem>
<CubeIcon /> 2
<Icon>
<CubeIcon />
</Icon>
2 <span className="pf-v6-screen-reader">Workspaces</span>
</FlexItem>
<FlexItem>
<CheckCircleIcon /> 11
<Icon status="success">
<CheckCircleIcon />
</Icon>
11 <span className="pf-v6-screen-reader">Completed</span>
</FlexItem>
<FlexItem>
<ExclamationTriangleIcon /> 4
<Icon status="warning">
<ExclamationTriangleIcon />
</Icon>
4 <span className="pf-v6-screen-reader">Warnings</span>
</FlexItem>
<FlexItem>
<TimesCircleIcon /> 1
<Icon status="danger">
<ExclamationCircleIcon />
</Icon>
1 <span className="pf-v6-screen-reader">Error</span>
</FlexItem>
<FlexItem> Updated 2 days ago</FlexItem>
</Flex>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import {
DataListItemCells,
Flex,
FlexItem,
Icon,
MenuToggle,
MenuToggleCheckbox,
OverflowMenu,
Expand Down Expand Up @@ -151,17 +152,29 @@ export const DataListStaticBottomPagination: React.FunctionComponent = () => {
<Flex flexWrap={{ default: 'wrap' }}>
<Flex spaceItems={{ default: 'spaceItemsSm' }}>
<FlexItem>
<CodeBranchIcon /> {threads}
<Icon>
<CodeBranchIcon />
</Icon>{' '}
{threads}
<span className="pf-v6-screen-reader">Branches</span>
</FlexItem>
</Flex>
<Flex spaceItems={{ default: 'spaceItemsSm' }}>
<FlexItem>
<CodeIcon /> {applications}
<Icon>
<CodeIcon />
</Icon>{' '}
{applications}
<span className="pf-v6-screen-reader">Code blocks</span>
</FlexItem>
</Flex>
<Flex spaceItems={{ default: 'spaceItemsSm' }}>
<FlexItem>
<CubeIcon /> {workspaces}
<Icon>
<CubeIcon />
</Icon>{' '}
{workspaces}
<span className="pf-v6-screen-reader">Workspaces</span>
</FlexItem>
</Flex>
<FlexItem> Updated {lastModified}</FlexItem>
Expand Down
7 changes: 5 additions & 2 deletions packages/react-core/src/demos/DataListDemo.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import CodeIcon from '@patternfly/react-icons/dist/esm/icons/code-icon';
import CubeIcon from '@patternfly/react-icons/dist/esm/icons/cube-icon';
import ExclamationTriangleIcon from '@patternfly/react-icons/dist/esm/icons/exclamation-triangle-icon';
import CheckCircleIcon from '@patternfly/react-icons/dist/esm/icons/check-circle-icon';
import TimesCircleIcon from '@patternfly/react-icons/dist/esm/icons/times-circle-icon';
import ExclamationCircleIcon from '@patternfly/react-icons/dist/esm/icons/exclamation-circle-icon';
import { DashboardWrapper } from '@patternfly/react-core/dist/js/demos/DashboardWrapper';
import { rows } from '@patternfly/react-core/dist/esm/demos/sampleData';

Expand All @@ -30,14 +30,17 @@ import { rows } from '@patternfly/react-core/dist/esm/demos/sampleData';
### Expandable control in toolbar

```js file="./DataList/examples/DataListExpandableControlInToolbar.tsx" isFullscreen

```

### Actionable

```js file="./DataList/examples/DataListActionable.tsx" isFullscreen

```

### Static bottom pagination

```js file="./DataList/examples/DataListStaticBottomPagination.tsx" isFullscreen
```

```
Loading