Skip to content

chore(DataList): provided context for demo icons #11966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

thatblindgeye
Copy link
Contributor

What: Closes #11965

Additional issues:

@patternfly-build
Copy link
Contributor

patternfly-build commented Aug 20, 2025

@thatblindgeye thatblindgeye requested review from a team, nicolethoen and rebeccaalpert and removed request for a team August 21, 2025 12:15
Copy link
Member

@rebeccaalpert rebeccaalpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reaching a little bit, but do we want to rename the variables in the static bottom pagination demo to make them more consistent with the screen-reader content?

I have an additional comment about singular text also - feel free to ignore if not relevant.

Copy link
Member

@rebeccaalpert rebeccaalpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataList - demos need additional context for icons with number text
3 participants