fix(Modal): Various bug fixes V5

[tlabaj]

What: Closes #11041

This fixes:

• Modal container getting aria-hidden = true when in StrictMode
• Modal adjacent siblings getting aria-hidden = true incorrectly removed
• Modal div getting created and not removed until refresh
• This also removes the wrapping container div that was use to append the modal to when creating a portal. Instead, we append directly to the documentation body by default (Newer react documentation shows this as an example). The consumer can still pass an element to append to the via the appendTo prop.

I also added .history to the eslint ignore.

The test example can be used to test out the Modal changes here and the Modal Next changes here. You can compare the examples with the original issue in the code sandbox that was provided by the reporter https://codesandbox.io/s/withered-frog-qc67dn?file=/index.js
cc @christianvogt

TODO:

• Remove the test examples
  - Make the same changes to the Modal next
• In the main branch make changes to the Modal and deprecated Modal.

[patternfly-build]

Preview: https://patternfly-react-pr-11168.surge.sh

A11y report: https://patternfly-react-pr-11168-a11y.surge.sh

[kmcfaul]

I'm a little confused by the test examples' text and want to confirm that we should not be seeing aria-hidden={false} on non-hidden modals. The text indicates to look for the attribute but it isn't present. And for the adjacent modal example, the text says to look for closed modals' attributes but the closed modals aren't in the DOM - which the PR indicates should be the case.

I think both behaviors make sense but want to make sure I'm not misunderstanding. If they are correct, then this PR LGTM.

[tlabaj]

@kmcfaul the example are directly copied from the code sandbox in the issue. SO the text in the example talks about the bug that was fixed. I agree that is confusing. I can update it.

[kmcfaul]

lgtm, just needs the test example removed

[mcoker]

🚀

[patternfly-build]

Your changes have been released in:

• @patternfly/[email protected]
• @patternfly/[email protected]
• @patternfly/[email protected]
• @patternfly/[email protected]
• @patternfly/[email protected]
• [email protected]
• @patternfly/[email protected]
• @patternfly/[email protected]

Thanks for your contribution! 🎉