Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update revive to 0.1.0-dev.8 #21

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Update revive to 0.1.0-dev.8 #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
- name: Install resolc
run: |
mkdir -p resolc
wget https://github.com/paritytech/revive/releases/download/v0.1.0-dev.7/resolc \
wget https://github.com/paritytech/revive/releases/download/v0.1.0-dev.8/resolc \
-O resolc/resolc && chmod +x resolc/resolc
echo "$(pwd)/resolc/" >> $GITHUB_PATH

Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
FROM node:22-bookworm-slim

ENV SOLC_VERSION="0.8.28"
ENV RESOLC_VERSION="0.1.0-dev.7"
ENV RESOLC_VERSION="0.1.0-dev.8"

# Install dependencies
RUN apt-get update && apt-get install -y \
Expand Down
2 changes: 1 addition & 1 deletion k8s/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ helm install prometheus-adapter prometheus-community/prometheus-adapter --namesp

```sh
eval $(minikube docker-env)
docker build --platform=linux/amd64 -t paritytech/revive-remix-backend:1.3.5 ../
docker build --platform=linux/amd64 -t paritytech/revive-remix-backend:1.3.6 ../
```

### Deploy your application and configure monitoring
Expand Down
2 changes: 1 addition & 1 deletion k8s/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ spec:
spec:
containers:
- name: revive-remix-backend
image: paritytech/revive-remix-backend:1.3.5
image: paritytech/revive-remix-backend:1.3.6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What versioning is this following?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now Minor update is the change in backend logic
Revive change is the Patch update

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would make sense to use the revive version in the tag? Then you don't need to do this when actually nothing changed: There can be multiple version of the revive-remix_backend but the images include different revive versions. As a side effect it's directly visible what compiler version is deployed too.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it may be the last backend release, so probably it does not make sense to introduce any changes now.

imagePullPolicy: IfNotPresent
ports:
- name: web
Expand Down
2 changes: 1 addition & 1 deletion k8s/pod.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ metadata:
spec:
containers:
- name: revive-remix-backend
image: paritytech/revive-remix-backend:1.3.5
image: paritytech/revive-remix-backend:1.3.6
ports:
- containerPort: 3000
resources:
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "revive-remix-backend",
"version": "1.3.5",
"version": "1.3.6",
"main": "server.js",
"scripts": {
"test": "mocha --exit",
Expand Down
Loading